Skip to content

remove safe_mode leftovers #19552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2025
Merged

remove safe_mode leftovers #19552

merged 2 commits into from
Aug 24, 2025

Conversation

jorgsowa
Copy link
Contributor

safe_mode ini directive was removed in PHP 5.4: dd8e59d

mvorisek
mvorisek reviewed Aug 22, 2025
View reviewed changes
ext/gd/php_gd.h
@@ -23,7 +23,6 @@

#if defined(HAVE_LIBGD) || defined(HAVE_GD_BUNDLED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are more mentions like

php-src/main/main.c

Line 733 in a84a82e

/* Only do the safemode/open_basedir check at runtime */

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, removed.

@devnexen
Copy link
Member

looking good at first glance, I ll have a better look once you finish cleaning up.

kallesommernielsen
kallesommernielsen approved these changes Aug 22, 2025
View reviewed changes
Copy link

@kallesommernielsen kallesommernielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the original author, thank you for finishing the job :)

@devnexen devnexen requested a review from a team August 22, 2025 09:57
@jorgsowa jorgsowa requested a review from Girgias as a code owner August 22, 2025 10:15
devnexen
devnexen approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

edorian
edorian approved these changes Aug 24, 2025
View reviewed changes
Copy link
Member

@edorian edorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No RM objections

@devnexen devnexen merged commit d6d0a2a into php:master Aug 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edorian edorian edorian approved these changes

@devnexen devnexen devnexen approved these changes

@kallesommernielsen kallesommernielsen kallesommernielsen approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

+1 more reviewer

@mvorisek mvorisek mvorisek left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ABI break Extension: gd Extension: session
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jorgsowa @devnexen @edorian @mvorisek @kallesommernielsen