Skip to content

Simplify SimpleXML code for checking if count() is overridden by a userland class #18722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Simplify SimpleXML code for checking if count() is overridden by a userland class #18722

merged 1 commit into from
May 31, 2025

Conversation

nielsdos
Copy link
Member

No description provided.

Girgias
Girgias approved these changes May 31, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh checking that the ce is a user class is smart, I think such an optimization could be used in a few other places.

@nielsdos nielsdos merged commit d2514e3 into php:master May 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: simplexml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias