Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed GH-18243: imagettftext underflow/overflow on size argument. #18245

Closed
wants to merge 4 commits into from
Closed

Fixed GH-18243: imagettftext underflow/overflow on size argument. #18245

wants to merge 4 commits into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Apr 4, 2025

No description provided.

@devnexen devnexen linked an issue Apr 4, 2025 that may be closed by this pull request
runtime error: 5.90296e+20 is outside the range of representable values of type 'long' in libgd #18243
Closed
nielsdos
nielsdos requested changes Apr 4, 2025
View reviewed changes
nielsdos
nielsdos reviewed Apr 5, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is mostly good, but you should also test NAN and INF. Do these work properly? If not, use the function zend_finite to check that the double is truly a number.

@devnexen devnexen closed this in fe8dffe Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: gd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error: 5.90296e+20 is outside the range of representable values of type 'long' in libgd
2 participants
@devnexen @nielsdos