Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-enの差分を反映(3) #141

Merged
merged 11 commits into from
Nov 4, 2024
Merged

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented Oct 31, 2024

以下のコミットの変更に追従しました

また、自分の名前(@zonuexe)をtranslation.xmlに追加しています。 (新規ファイルのメンテナに自分を指名しているため)

@zonuexe zonuexe force-pushed the follow/doc-en-3 branch 2 times, most recently from 9d3413a to 40e9dec Compare October 31, 2024 14:46

<simpara>
構成スクリプトが実行された後、<command>make</command> コマンドを使用して PHP
をビルドできます。このマニュアルの<link linkend="install.problems">問題が起きた場合</link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is causing the build failure, should be:
<link linkend="faq.installation">Installation section of the frequently asked questions</link> if this is being synced with EN

@Girgias
Copy link
Member

Girgias commented Oct 31, 2024

Okay the build fails due to RelaxNG failures, some are related to the DOM documentation not being synced.

@Girgias Girgias mentioned this pull request Oct 31, 2024
Tried to put more emphasis on how to install from packages (either
from distributions or third parties) and for Unix, in particular, move
the stuff about compiling from source down a level so new users don't
get knocked in the face with it.

php/doc-en@4cb53ec
@zonuexe
Copy link
Contributor Author

zonuexe commented Oct 31, 2024

@Girgias The build is now green. Thank you for your support!

zonuexe and others added 3 commits November 2, 2024 04:53
Co-authored-by: Takuya Aramaki <[email protected]>
Co-authored-by: Takuya Aramaki <[email protected]>
Co-authored-by: Takuya Aramaki <[email protected]>
Copy link
Contributor

@youkidearitai youkidearitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ありがとうございます!

@youkidearitai youkidearitai merged commit ab17f81 into php:master Nov 4, 2024
1 check passed
@youkidearitai
Copy link
Contributor

ありがとうございます!

@zonuexe zonuexe deleted the follow/doc-en-3 branch November 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants