Imagick::getResourceLimit、setResourceLimitの説明を修正 #129
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youkidearitai
approved these changes
Sep 29, 2024
|
@youkidearitai |
|
@muno92 ありがとうございました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php/doc-en#2037 の変更を取り込んでImagick::getResourceLimitの説明を調整しました。
また、その確認をしていて対になるsetResourceLimitの説明に英語版と差異があることを見つけたので修正しています。
https://www.php.net/manual/en/imagick.setresourcelimit.php
https://www.php.net/manual/ja/imagick.setresourcelimit.php
setResourceLimitはtypeに応じてlimitの単位が変わってくるので、単位についての記載はlimit側にのみあるのが適切ではないかと考えました。
（setResourceLimitの引数limitの説明を英語版に揃えて「異なります」から「依存します」にした方が良いのだろうか、と思いましたがそこまで調整すると話が広がる気がしたのでtypeの説明から単位についての記載を取り除くのみにしています。）