Document memcached.sess_binary_protocol #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Amazing! |
Member
|
But conflicts at the moment |
64a115d to
fbdc4bb
Compare
Contributor
Author
|
Fixed merge conflicts, probably from whitespace changes. |
And remove a TODO found in the code for allowing users to configure whether or not to use binary protocols for sessions. For issue php-memcached-dev#233
fbdc4bb to
045ab84
Compare
Contributor
Author
|
The conflicts were fixed months ago, please look at this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove a TODO found in the code for allowing users to configure
whether or not to use binary protocols for sessions.
If there are any comments on formatting, what the comment for memcached.sess_binary_protocol should say, etc., I'll change my PR to address them.
For issue #233