Fix PcgOneseq128XslRr64::__construct() definition in random.stub.php (php#9235)

TimWolla · web-flow · commit db84e446070e · 2022-08-02T18:54:39.000+02:00
* Fix PcgOneseq128XslRr64::__construct() definition in random.stub.php

The second parameter does not actually exist for a Oneseq PCG. It was removed
from the RFC before it went into voting.

* [ci skip] Add PcgOneseq128XslRr64 stub fix to NEWS
diff --git a/NEWS b/NEWS
@@ -3,6 +3,8 @@ PHP                                                                        NEWS
 ?? ??? ????, PHP 8.2.0beta3
 
 - Random:
+  . Fixed bug GH-9235 (non-existant $sequence parameter in stub for
+    PcgOneseq128XslRr64::__construct()). (timwolla)
   . Removed redundant RuntimeExceptions from Randomizer methods. The
     exceptions thrown by the engines will be exposed directly. (timwolla)
 
diff --git a/ext/random/random.stub.php b/ext/random/random.stub.php
@@ -59,7 +59,7 @@ public function __debugInfo(): array {}
      */
     final class PcgOneseq128XslRr64 implements \Random\Engine
     {
-        public function __construct(string|int|null $seed = null, string|int $sequence = 0) {}
+        public function __construct(string|int|null $seed = null) {}
 
         /** @implementation-alias Random\Engine\Mt19937::generate */
         public function generate(): string {}
diff --git a/ext/random/random_arginfo.h b/ext/random/random_arginfo.h

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function __debugInfo(): array {}`
`59`	`59`	`*/`
`60`	`60`	`final class PcgOneseq128XslRr64 implements \Random\Engine`
`61`	`61`	`{`
`62`		`- public function __construct(string\|int\|null $seed = null, string\|int $sequence = 0) {}`
	`62`	`+ public function __construct(string\|int\|null $seed = null) {}`
`63`	`63`
`64`	`64`	`/** @implementation-alias Random\Engine\Mt19937::generate */`
`65`	`65`	`public function generate(): string {}`