Skip to content

Fix PcgOneseq128XslRr64::__construct() definition in random.stub.php #9235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Aug 2, 2022

The second parameter does not actually exist for a Oneseq PCG. It was removed
from the RFC before it went into voting.

The second parameter does not actually exist for a Oneseq PCG. It was removed
from the RFC before it went into voting.
@zeriyoshi zeriyoshi self-requested a review August 2, 2022 16:11
Copy link
Contributor

@zeriyoshi zeriyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I had missed it completely. Thank you.
I will create a cleanup PR tomorrow as there are a lot of areas (almost a tests) of concern when I look back at it.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@TimWolla TimWolla merged commit db84e44 into php:master Aug 2, 2022
@TimWolla TimWolla deleted the random-stub-pcg branch August 2, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants