BUG: OverflowError when fillna on DataFrame with a pd.Timestamp (#61208) #61216
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d.Timestamp - Now correctly raises OutOfBoundsDatetime - Added test_fillna_out_of_bounds_datetime()
yuanx749
reviewed
Apr 2, 2025
yuanx749
approved these changes
Apr 3, 2025
rhshadrach
requested changes
Apr 12, 2025
|
|
||
| msg = "Cannot cast 0001-01-01 00:00:00 to unit='ns' without overflow" | ||
| with pytest.raises(OutOfBoundsDatetime, match=msg): | ||
| df.fillna(Timestamp("0001-01-01"), inplace=True) |
There was a problem hiding this comment.
Can you remove inplace=True; that argument is going to be removed in a future pandas version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now correctly raises OutOfBoundsDatetime
Added test_fillna_out_of_bounds_datetime()
closes BUG: OverflowError when fillna on DataFrame with a pd.Timestamp #61208
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions. (does not apply)
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Fix for
fillnawith Out-of-Bounds Datetime ValuesIssue: Using
fillnaon adatetime64[ns]column with an out-of-bounds timestamp (e.g.,'0001-01-01') raised anAssertionErrorinstead of the expectedOutOfBoundsDatetime.Fix: Modified the
putmaskmethod inpandas/core/internals/blocks.pyto catch and re-raiseOutOfBoundsDatetimedirectly, preventing theAssertionError.Test Added:
test_fillna_out_of_bounds_datetimeinpandas/tests/frame/methods/test_fillna.py.datetime64[ns]column containingNaT.NaTwith'0001-01-01'.OutOfBoundsDatetime.