Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix pyarrow categoricals not working for pivot and multiindex #61193

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

robin-mader-bis
Copy link

@robin-mader-bis robin-mader-bis commented Mar 28, 2025

Disclaimer THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

@robin-mader-bis robin-mader-bis changed the title BUG: multiindex pyarrow categoricals BUG: Fix pyarrow categoricals not working for pivot and categoricals Mar 28, 2025
@robin-mader-bis robin-mader-bis force-pushed the fix/multiindex-pyarrow-categoricals branch 6 times, most recently from 3b6a2fd to 864da12 Compare April 4, 2025 07:07
@robin-mader-bis robin-mader-bis marked this pull request as ready for review April 4, 2025 11:37
@robin-mader-bis robin-mader-bis changed the title BUG: Fix pyarrow categoricals not working for pivot and categoricals BUG: Fix pyarrow categoricals not working for pivot and multiindex Apr 4, 2025
@robin-mader-bis
Copy link
Author

Hey @mroeschke,
Thanks for the Review! All comments should be adressed. Could you have another look if everything looks good?

@robin-mader-bis robin-mader-bis force-pushed the fix/multiindex-pyarrow-categoricals branch 2 times, most recently from fc2bad5 to d859236 Compare April 11, 2025 06:35
@robin-mader-bis
Copy link
Author

Hey @mroeschke,
Thanks again for the review. All feedback should be addressed. Can you have another look?

@robin-mader-bis robin-mader-bis force-pushed the fix/multiindex-pyarrow-categoricals branch from a17fc48 to 096f6eb Compare April 14, 2025 11:38
@robin-mader-bis robin-mader-bis force-pushed the fix/multiindex-pyarrow-categoricals branch from 096f6eb to 5e53fec Compare April 14, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.pivot fails with pyarrow backend if variable is already encoded as dictionary
2 participants