Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix some docstring validation errors #59698 #59713

Merged
merged 4 commits into from
Sep 6, 2024
Merged

DOC: Fix some docstring validation errors #59698 #59713

merged 4 commits into from
Sep 6, 2024

Conversation

amanlai
Copy link
Contributor

@amanlai amanlai commented Sep 5, 2024

Part of an effort to close #59698

Added missing "See Also" section to the following methods:

pandas.TimedeltaIndex.components
pandas.TimedeltaIndex.microseconds

and updated undocumented parameters for the following method:

pandas.Timedelta.to_numpy

Removed the following strings from code_checks.sh:

 -i "pandas.Timedelta.to_numpy PR01" \ 
 -i "pandas.TimedeltaIndex.components SA01" \ 
 -i "pandas.TimedeltaIndex.microseconds SA01" \

@mroeschke mroeschke added the Docs label Sep 6, 2024
@mroeschke mroeschke added this to the 3.0 milestone Sep 6, 2024
@mroeschke mroeschke merged commit 3a45265 into pandas-dev:main Sep 6, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @amanlai

@amanlai amanlai deleted the validate-docstring-Timedelta/TimedeltaIndex#59698 branch September 6, 2024 02:34
@rhshadrach
Copy link
Member

rhshadrach commented Sep 15, 2024

@amanlai - just as a note, if you have "close" on the same line as an issue number, GitHub will automatically close the issue when your PR is merged. Best to just have something like "Part of #XXXXXX".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: fix docstring validation errors for pandas.Timedelta/pandas.TimedeltaIndex
3 participants