WEB: Refine PDEP presentation #58791
Conversation
| h2:hover a.headerlink { | ||
| opacity: 1; | ||
| transition: opacity 0.5s; | ||
| } | ||
| h3:hover a.headerlink { | ||
| opacity: 1; | ||
| transition: opacity 0.5s; | ||
| } |
There was a problem hiding this comment.
I think we should be able to combine these two, but wasn't able to figure out the syntax.
| body = markdown.markdown( | ||
| content, extensions=context["main"]["markdown_extensions"] | ||
| ) | ||
| if "pdeps/" in fname: |
There was a problem hiding this comment.
Because of the use of TocExtension below, we can't use the usual yaml. Not sure if there is a work around or a better approach here.
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/58791/ |
|
PDEP6 shows code highlighting. |
|
@rhshadrach thanks a lot for looking into this! I certainly think this is a nice improvement, and if we don't have agreement on using sphinx instead, we should definitely merge this one. But if you ask my honest opinion, I personally still think #51467 gives the better result. Concrete feedback on the changes here:
|
|
Personal preference, but I think the "On this page" sidebar (from @jorisvandenbossche's PR) is cleaner and resembles the docs more than the table of contents here. (I guess that's a benefit of using Sphinx?) |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Alternative to #51467. I believe this address all items in the linked issue. The main benefit in not switching to publishing PDEPs in sphinx is that it then matches the style of the rest of the webpage.
This is just a rough version to demonstrate what's possible, some refinements (highlighted below) need to be made if we are to merge this.