Skip to content

BUG: SparseSeries constructor ignores input data name #10258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2015
Merged

BUG: SparseSeries constructor ignores input data name #10258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.16.2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ Bug Fixes


- Bug in GroupBy.get_group raises ValueError when group key contains NaT (:issue:`6992`)

- Bug in ``SparseSeries`` constructor ignores input data name (:issue:`10258`)

- Bug where infer_freq infers timerule (WOM-5XXX) unsupported by to_offset (:issue:`9425`)
3 changes: 3 additions & 0 deletions pandas/sparse/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ def __init__(self, data=None, index=None, sparse_index=None, kind='block',
if data is None:
data = []

if isinstance(data, Series) and name is None:
name = data.name

is_sparse_array = isinstance(data, SparseArray)
if fill_value is None:
if is_sparse_array:
Expand Down
30 changes: 20 additions & 10 deletions pandas/sparse/tests/test_sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,22 +128,23 @@ def setUp(self):

date_index = bdate_range('1/1/2011', periods=len(index))

self.bseries = SparseSeries(arr, index=index, kind='block')
self.bseries.name = 'bseries'
self.bseries = SparseSeries(arr, index=index, kind='block',
name='bseries')

self.ts = self.bseries

self.btseries = SparseSeries(arr, index=date_index, kind='block')

self.iseries = SparseSeries(arr, index=index, kind='integer')
self.iseries = SparseSeries(arr, index=index, kind='integer',
name='iseries')

arr, index = _test_data2()
self.bseries2 = SparseSeries(arr, index=index, kind='block')
self.iseries2 = SparseSeries(arr, index=index, kind='integer')

arr, index = _test_data1_zero()
self.zbseries = SparseSeries(arr, index=index, kind='block',
fill_value=0)
fill_value=0, name='zbseries')
self.ziseries = SparseSeries(arr, index=index, kind='integer',
fill_value=0)

Expand Down Expand Up @@ -234,12 +235,21 @@ def test_constructor(self):
self.bseries.to_dense().fillna(0).values)

# pass SparseSeries
s2 = SparseSeries(self.bseries)
s3 = SparseSeries(self.iseries)
s4 = SparseSeries(self.zbseries)
assert_sp_series_equal(s2, self.bseries)
assert_sp_series_equal(s3, self.iseries)
assert_sp_series_equal(s4, self.zbseries)
def _check_const(sparse, name):
# use passed series name
result = SparseSeries(sparse)
assert_sp_series_equal(result, sparse)
self.assertEqual(sparse.name, name)
self.assertEqual(result.name, name)

# use passed name
result = SparseSeries(sparse, name='x')
assert_sp_series_equal(result, sparse)
self.assertEqual(result.name, 'x')

_check_const(self.bseries, 'bseries')
_check_const(self.iseries, 'iseries')
_check_const(self.zbseries, 'zbseries')

# Sparse time series works
date_index = bdate_range('1/1/2000', periods=len(self.bseries))
Expand Down