feat: use int64 type for claims with timestamps#600
Merged
aeneasr merged 2 commits intoory:masterfrom May 28, 2021
Merged
Conversation
Contributor
|
@aeneasr and @mitar: This PR transform claims with timestamps to |
72a7744 to
223ced5
Compare
223ced5 to
b6a09a0
Compare
mitar
reviewed
May 25, 2021
mitar
reviewed
May 25, 2021
mitar
reviewed
May 25, 2021
Contributor
|
I like it! |
Member
|
Could you please take a look at the failing test cases? Thanks! :) |
b31afb3 to
346c3d7
Compare
Contributor
|
fixed |
346c3d7 to
725b149
Compare
aeneasr
approved these changes
May 28, 2021
Contributor
|
@aeneasr my pleasure :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Uses
int64for timestamped claim values.Checklist
and signed the CLA.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).