Skip to content

Comments

fix: added missing factory to compose#472

Merged
aeneasr merged 1 commit intoory:masterfrom
ezerw:bugfix-token-revocation
Sep 12, 2020
Merged

fix: added missing factory to compose#472
aeneasr merged 1 commit intoory:masterfrom
ezerw:bugfix-token-revocation

Conversation

@ezerw
Copy link
Contributor

@ezerw ezerw commented Sep 11, 2020

Related issue

Reported the issue on the fosite-example repo #32

Proposed changes

Currently revoke access or refresh token functionality is not working in the fosite-example repo because of the missing OAuth2TokenRevocationFactory as part of the OAuth provider initialisation so when loading the factories it didn't load and append the revoke handlers.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

No further comments, it's a tiny PR and self explanatory

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2020

CLA assistant check
All committers have signed the CLA.

@ezerw ezerw changed the title Bugfix - Added missing OAuth2TokenRevocationFactory to ComposeAllEnabled bugfix: added missing factory to compose Sep 11, 2020
@ezerw ezerw changed the title bugfix: added missing factory to compose fix: added missing factory to compose Sep 11, 2020
@aeneasr
Copy link
Member

aeneasr commented Sep 12, 2020

Great, thank you!

@aeneasr aeneasr merged commit 88587fd into ory:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants