feat: Set default issuer in JWT tokens#444
Merged
aeneasr merged 1 commit intoory:masterfrom Jun 22, 2020
Merged
Conversation
mitar
commented
Jun 17, 2020
9ac1e93 to
20263c0
Compare
Member
|
Great, thank you! |
Contributor
Author
|
Any plans to release/bump version? |
Member
|
done v0.32.1 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is backwards incompatible change, but it allows one to set default issuer which seems to not be possible otherwise, despite being existing in the
DefaultJWTStrategystruct.Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.