Skip to content

Comments

feat: Set default issuer in JWT tokens#444

Merged
aeneasr merged 1 commit intoory:masterfrom
mitar:set-default-issuer
Jun 22, 2020
Merged

feat: Set default issuer in JWT tokens#444
aeneasr merged 1 commit intoory:masterfrom
mitar:set-default-issuer

Conversation

@mitar
Copy link
Contributor

@mitar mitar commented Jun 17, 2020

Proposed changes

This is backwards incompatible change, but it allows one to set default issuer which seems to not be possible otherwise, despite being existing in the DefaultJWTStrategy struct.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

@mitar mitar force-pushed the set-default-issuer branch from 9ac1e93 to 20263c0 Compare June 18, 2020 20:56
@mitar mitar requested a review from aeneasr June 18, 2020 20:56
@aeneasr
Copy link
Member

aeneasr commented Jun 22, 2020

Great, thank you!

@aeneasr aeneasr merged commit 901e206 into ory:master Jun 22, 2020
@mitar mitar deleted the set-default-issuer branch June 22, 2020 21:10
@mitar
Copy link
Contributor Author

mitar commented Jun 22, 2020

Any plans to release/bump version?

@aeneasr
Copy link
Member

aeneasr commented Jun 23, 2020

done v0.32.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants