Skip to content

Comments

feat: Making RemoveEmpty public#443

Merged
aeneasr merged 2 commits intoory:masterfrom
mitar:public-helper
Jun 5, 2020
Merged

feat: Making RemoveEmpty public#443
aeneasr merged 2 commits intoory:masterfrom
mitar:public-helper

Conversation

@mitar
Copy link
Contributor

@mitar mitar commented Jun 4, 2020

A very small change just to expose this method because I need for my own parsing of scopes and no point in duplicating it.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

}

tt, ar, err := f.IntrospectToken(ctx, token, TokenType(tokenType), session, strings.Split(scope, " ")...)
tt, ar, err := f.IntrospectToken(ctx, token, TokenType(tokenType), session, RemoveEmpty(strings.Split(scope, " "))...)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this while working on this.

@aeneasr
Copy link
Member

aeneasr commented Jun 5, 2020

Thank you!

@aeneasr aeneasr merged commit 17b0756 into ory:master Jun 5, 2020
@mitar mitar deleted the public-helper branch June 5, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants