Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ARC & L2ARC hit/miss bytes to arcstat #16726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkittich
Copy link
Contributor

@tkittich tkittich commented Nov 6, 2024

Motivation and Context

Currently there's no way to see the actual bytes hit/miss from the ARC & L2ARC.

Description

This PR adds number of bytes that were hit/miss from ARC & L2ARC to arcstat.

How Has This Been Tested?

Tested and working in a local VM. Not sure if there're any corner cases though.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Add number of bytes that were hit/miss from ARC & L2ARC to arcstat

Signed-off-by: Theera K. <[email protected]>
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if hits and hit_bytes (and similarly misses) were accounted together and same way. And you've completely missed iohits. And for L2ARC it seems hit_bytes duplicates read_bytes.

@amotin amotin added Status: Code Review Needed Ready for review and testing Status: Revision Needed Changes are required for the PR to be accepted labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing Status: Revision Needed Changes are required for the PR to be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants