host: Switch to inline postprocess element#316
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 26, 2018
Merged
host: Switch to inline postprocess element#316openshift-merge-robot merged 1 commit intoopenshift:masterfrom
postprocess element#316openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
dustymabe
reviewed
Sep 26, 2018
| Information: https://url.corp.redhat.com/redhat-coreos | ||
| Bugs: https://github.com/openshift/os | ||
| --- | ||
| EOF |
Member
There was a problem hiding this comment.
in the old file there was an extra newline between the --- and the EOF. Don't know if we want to keep that or not or if it's possible with inline yaml
Member
There was a problem hiding this comment.
This is slight bikeshed but... why not keep the newline separators in the actual script itself too? Makes it much nicer to read through it. At least PyYAML definitely supports that. I'd be surprised if serde didn't.
Member
|
did a vimdiff between the old file and new ones. one small comment. LGTM |
dustymabe
approved these changes
Sep 26, 2018
The primary reason I'm doing this is that today rpm-ostree's treefile inheritance doesn't quite do what one wants with external files. There's some major work on that in coreos/rpm-ostree#1574 But let's not block on/require it. Furthermore, using the inline `postprocess` value allows us to clearly demarcate the `maipo`-specific hacks in that file.
e5be9a1 to
2fe5800
Compare
ashcrow
approved these changes
Sep 26, 2018
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary reason I'm doing this is that today rpm-ostree's
treefile inheritance doesn't quite do what one wants with external
files. There's some major work on that in
coreos/rpm-ostree#1574
But let's not block on/require it.
Furthermore, using the inline
postprocessvalue allows usto clearly demarcate the
maipo-specific hacks in that file.