Skip to content

Drop LVM, use custom growpart wrapper#294

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:no-lvm-custom-growpart
Sep 17, 2018
Merged

Drop LVM, use custom growpart wrapper#294
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:no-lvm-custom-growpart

Conversation

@cgwalters
Copy link
Member

Closes: #293

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2018
@cgwalters
Copy link
Member Author

Requires: coreos/coreos-assembler#95

@cgwalters
Copy link
Member Author

Actually unless we backport coreos/fedora-coreos-config@0fdb511 the commits interlock - pushing one without the other will be broken.

compose-post.sh Outdated
[Service]
ExecStart=/usr/libexec/coreos-growpart /
RemainAfterExit=yes
Before=sshd.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Before= required to be under the [Unit] section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it's just ignored.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've submitted coreos/fedora-coreos-config#10.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coreos/fedora-coreos-config#11

And updated below ⬇️

@ashcrow
Copy link
Member

ashcrow commented Sep 17, 2018

@cgwalters Can that be backported in this PR set or do we need to keep them separate?

@cgwalters cgwalters force-pushed the no-lvm-custom-growpart branch from 8ef4cd0 to 5ca3e89 Compare September 17, 2018 17:34
@cgwalters
Copy link
Member Author

@cgwalters Can that be backported in this PR set or do we need to keep them separate?

Wouldn't hurt but wouldn't help either - the problem is once we build a new coreos-assembler:alpha. But we can just wait to do that until this merges.

@dm0-
Copy link
Contributor

dm0- commented Sep 17, 2018

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants