jenkins: Create a prepare_configuration() helper#292
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 17, 2018
Merged
jenkins: Create a prepare_configuration() helper#292openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
More followup for cri-o+ootpa. We need to inject the cert in the ootpa job too. Let's define a common helper for this and also run it early, since it doesn't depend on anything else. (Ideally this would somehow be possible to run locally from the `Makefile` but that really requires splitting out the "not-actually-credentials" into an internal git repo or something)
yuqi-zhang
approved these changes
Sep 17, 2018
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More followup for cri-o+ootpa. We need to inject the cert in
the ootpa job too. Let's define a common helper for this and
also run it early, since it doesn't depend on anything else.
(Ideally this would somehow be possible to run locally from
the
Makefilebut that really requires splitting out the"not-actually-credentials" into an internal git repo or something)