Skip to content

maipo: Delete lua interpreters#279

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:drop-lua-interp
Sep 6, 2018
Merged

maipo: Delete lua interpreters#279
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:drop-lua-interp

Conversation

@cgwalters
Copy link
Member

Closes: #275

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2018

remove-from-packages:
# https://github.com/openshift/os/issues/275
- - lua
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like valid YAML syntax. Just verifying that it's proper for this implementation of the parser.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also I did test this locally)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well alright :-)

@ashcrow
Copy link
Member

ashcrow commented Sep 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
@openshift-merge-robot openshift-merge-robot merged commit 6ea36c0 into openshift:master Sep 6, 2018
@jlebon
Copy link
Member

jlebon commented Sep 6, 2018

(Sidenote: we should tweak the syntax-check target to cover YAML files too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants