STOR-2002: add Azure File snapshot support #253

RomanBednar · 2024-08-02T11:36:44Z

Basic verification for snapshot create and restore

Driver logs with successful PVC and snapshot creation:

I0802 11:27:44.523693       1 utils.go:101] GRPC call: /csi.v1.Controller/CreateVolume
I0802 11:27:44.523715       1 utils.go:102] GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","parameters":{"csi.storage.k8s.io/pv/name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","csi.storage.k8s.io/pvc/name":"pvc-1","csi.storage.k8s.io/pvc/namespace":"default","skuName":"Standard_LRS"},"volume_capabilities":[{"AccessType":{"Mount":{"fs_type":"ext4","mount_flags":["mfsymlinks","cache=strict","nosharesock","actimeo=30"]}},"access_mode":{"mode":7}}]}
I0802 11:27:45.199848       1 controllerserver.go:561] begin to create file share(pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6) on account(clusterewxps) type(Standard_LRS) subID() rg(rbednar-mycluster-01-wnmgz-rg) location() size(1) protocol(SMB)
I0802 11:27:45.586538       1 controllerserver.go:593] create file share pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6 on storage account clusterewxps successfully
I0802 11:27:45.607282       1 controllerserver.go:639] store account key to k8s secret(azure-storage-account-clusterewxps-secret) in default namespace
I0802 11:27:45.607340       1 utils.go:108] GRPC response: {"volume":{"capacity_bytes":1073741824,"volume_context":{"csi.storage.k8s.io/pv/name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","csi.storage.k8s.io/pvc/name":"pvc-1","csi.storage.k8s.io/pvc/namespace":"default","secretnamespace":"default","skuName":"Standard_LRS"},"volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}}
I0802 11:28:00.070584       1 utils.go:101] GRPC call: /csi.v1.Identity/GetPluginInfo
I0802 11:28:00.070604       1 utils.go:102] GRPC request: {}
I0802 11:28:00.070645       1 utils.go:108] GRPC response: {"name":"file.csi.azure.com","vendor_version":"v1.30.3"}
I0802 11:28:00.071131       1 utils.go:101] GRPC call: /csi.v1.Controller/CreateSnapshot
I0802 11:28:00.071144       1 utils.go:102] GRPC request: {"name":"snapshot-9cde69ce-2e33-4f32-b4ba-471b04549904","source_volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}
I0802 11:28:00.414963       1 controllerserver.go:915] created share snapshot: 2024-08-02T11:28:00.0000000Z, time: 2024-08-02 11:28:00 +0000 UTC, quota: 0GiB
I0802 11:28:00.415040       1 utils.go:108] GRPC response: {"snapshot":{"creation_time":{"seconds":1722598080},"ready_to_use":true,"size_bytes":107374182400,"snapshot_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default#2024-08-02T11:28:00.0000000Z","source_volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}}

Driver logs during snapshot restore:

I0802 11:29:33.283200       1 controllerserver.go:1098] copied fileshare pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6(snapshot: 2024-08-02T11:28:00.0000000Z) to pvc-10e9e706-2427-46c4-b988-bf7aa228e718 successfully
I0802 11:29:33.283262       1 controllerserver.go:593] create file share pvc-10e9e706-2427-46c4-b988-bf7aa228e718 on storage account clusterewxps successfully
I0802 11:29:33.283302       1 utils.go:108] GRPC response: {"volume":{"capacity_bytes":107374182400,"content_source":{"Type":{"Snapshot":{"snapshot_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default#2024-08-02T11:28:00.0000000Z"}}},"volume_context":{"csi.storage.k8s.io/pv/name":"pvc-10e9e706-2427-46c4-b988-bf7aa228e718","csi.storage.k8s.io/pvc/name":"pvc-1-snapshot-restore","csi.storage.k8s.io/pvc/namespace":"default","secretnamespace":"default","skuName":"Standard_LRS"},"volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-10e9e706-2427-46c4-b988-bf7aa228e718###default"}}

Snapshot restored successfully:

 oc get pvc/pvc-1-snapshot-restore
NAME                     STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS    VOLUMEATTRIBUTESCLASS   AGE
pvc-1-snapshot-restore   Bound    pvc-10e9e706-2427-46c4-b988-bf7aa228e718   100Gi      RWO            azurefile-csi   <unset>                 2m23s

cc @openshift/storage

openshift-ci · 2024-08-02T11:37:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RomanBednar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RomanBednar · 2024-08-02T14:37:03Z

/retest-required

jsafrane · 2024-08-05T09:06:14Z

assets/overlays/azure-file/generated/hypershift/controller.yaml

        - --extra-create-metadata=true
-        - --timeout=300s
+        - --strict-topology=true
+        - --timeout=30s


This changes the timeout from 300s to 30s, which is IMO bad.

(upstream uses 1200s !?)

1200s seems a lot, I've set 300s now and we can increase it later if we see issues.

jsafrane · 2024-08-05T09:06:35Z

assets/overlays/azure-file/generated/hypershift/controller.yaml

@@ -169,8 +173,14 @@ spec:
        - --leader-election-retry-period=${LEADER_ELECTION_RETRY_PERIOD}
        - --leader-election-namespace=openshift-cluster-csi-drivers
        - --v=${LOG_LEVEL}
+        - --default-fstype=ext4


this is bad for Samba / NFS, they don't support ext4

Right, it should be left unset - removing.

jsafrane · 2024-08-05T09:09:00Z

assets/overlays/azure-file/generated/hypershift/controller.yaml

+        - --feature-gates=Topology=true
        - --extra-create-metadata=true
-        - --timeout=300s
+        - --strict-topology=true


Why these changes? Topology and strict-topology not in the upstream deployment.

That's a mistake, removing.

RomanBednar · 2024-08-06T12:01:32Z

The problem with snapshot restore size turned out to be a bug in the driver. Upstream posted a fix real quick and I've re-tested the failing CI tests with that fix and they passed for me: kubernetes-sigs/azurefile-csi-driver#2040

So we need to wait for upstream merge, follow with a cherry-pick and we should be good with this PR.

EDIT: upstream fix is merged now, opening cherry-pick PR

openshift-ci-robot · 2024-08-06T14:03:38Z

@RomanBednar: This pull request references STOR-2002 which is a valid jira issue.

In response to this:

Basic verification for snapshot create and restore

Driver logs with successful PVC and snapshot creation:

I0802 11:27:44.523693       1 utils.go:101] GRPC call: /csi.v1.Controller/CreateVolume
I0802 11:27:44.523715       1 utils.go:102] GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","parameters":{"csi.storage.k8s.io/pv/name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","csi.storage.k8s.io/pvc/name":"pvc-1","csi.storage.k8s.io/pvc/namespace":"default","skuName":"Standard_LRS"},"volume_capabilities":[{"AccessType":{"Mount":{"fs_type":"ext4","mount_flags":["mfsymlinks","cache=strict","nosharesock","actimeo=30"]}},"access_mode":{"mode":7}}]}
I0802 11:27:45.199848       1 controllerserver.go:561] begin to create file share(pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6) on account(clusterewxps) type(Standard_LRS) subID() rg(rbednar-mycluster-01-wnmgz-rg) location() size(1) protocol(SMB)
I0802 11:27:45.586538       1 controllerserver.go:593] create file share pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6 on storage account clusterewxps successfully
I0802 11:27:45.607282       1 controllerserver.go:639] store account key to k8s secret(azure-storage-account-clusterewxps-secret) in default namespace
I0802 11:27:45.607340       1 utils.go:108] GRPC response: {"volume":{"capacity_bytes":1073741824,"volume_context":{"csi.storage.k8s.io/pv/name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","csi.storage.k8s.io/pvc/name":"pvc-1","csi.storage.k8s.io/pvc/namespace":"default","secretnamespace":"default","skuName":"Standard_LRS"},"volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}}
I0802 11:28:00.070584       1 utils.go:101] GRPC call: /csi.v1.Identity/GetPluginInfo
I0802 11:28:00.070604       1 utils.go:102] GRPC request: {}
I0802 11:28:00.070645       1 utils.go:108] GRPC response: {"name":"file.csi.azure.com","vendor_version":"v1.30.3"}
I0802 11:28:00.071131       1 utils.go:101] GRPC call: /csi.v1.Controller/CreateSnapshot
I0802 11:28:00.071144       1 utils.go:102] GRPC request: {"name":"snapshot-9cde69ce-2e33-4f32-b4ba-471b04549904","source_volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}
I0802 11:28:00.414963       1 controllerserver.go:915] created share snapshot: 2024-08-02T11:28:00.0000000Z, time: 2024-08-02 11:28:00 +0000 UTC, quota: 0GiB
I0802 11:28:00.415040       1 utils.go:108] GRPC response: {"snapshot":{"creation_time":{"seconds":1722598080},"ready_to_use":true,"size_bytes":107374182400,"snapshot_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default#2024-08-02T11:28:00.0000000Z","source_volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}}

Driver logs during snapshot restore:

I0802 11:29:33.283200       1 controllerserver.go:1098] copied fileshare pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6(snapshot: 2024-08-02T11:28:00.0000000Z) to pvc-10e9e706-2427-46c4-b988-bf7aa228e718 successfully
I0802 11:29:33.283262       1 controllerserver.go:593] create file share pvc-10e9e706-2427-46c4-b988-bf7aa228e718 on storage account clusterewxps successfully
I0802 11:29:33.283302       1 utils.go:108] GRPC response: {"volume":{"capacity_bytes":107374182400,"content_source":{"Type":{"Snapshot":{"snapshot_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default#2024-08-02T11:28:00.0000000Z"}}},"volume_context":{"csi.storage.k8s.io/pv/name":"pvc-10e9e706-2427-46c4-b988-bf7aa228e718","csi.storage.k8s.io/pvc/name":"pvc-1-snapshot-restore","csi.storage.k8s.io/pvc/namespace":"default","secretnamespace":"default","skuName":"Standard_LRS"},"volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-10e9e706-2427-46c4-b988-bf7aa228e718###default"}}

Snapshot restored successfully:

oc get pvc/pvc-1-snapshot-restore
NAME                     STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS    VOLUMEATTRIBUTESCLASS   AGE
pvc-1-snapshot-restore   Bound    pvc-10e9e706-2427-46c4-b988-bf7aa228e718   100Gi      RWO            azurefile-csi   <unset>                 2m23s

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dobsonj · 2024-08-06T16:29:16Z

/retest
/label docs-approved
/label px-approved

dobsonj · 2024-08-06T20:01:01Z

/retest

dobsonj · 2024-08-06T22:22:07Z

/test e2e-azure-file-csi

duanwei33 · 2024-08-07T09:15:21Z

The CI azure-file-csi/azure-file-csi-extended/azure-csi-extended all good.

duanwei33 · 2024-08-07T09:15:48Z

/label pe-approved

openshift-ci · 2024-08-07T09:15:52Z

@duanwei33: The label(s) /label pe-approved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label pe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

duanwei33 · 2024-08-07T09:42:10Z

/label qe-approved

openshift-ci-robot · 2024-08-07T09:42:17Z

@RomanBednar: This pull request references STOR-2002 which is a valid jira issue.

In response to this:

Basic verification for snapshot create and restore

Driver logs with successful PVC and snapshot creation:

I0802 11:27:44.523693       1 utils.go:101] GRPC call: /csi.v1.Controller/CreateVolume
I0802 11:27:44.523715       1 utils.go:102] GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","parameters":{"csi.storage.k8s.io/pv/name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","csi.storage.k8s.io/pvc/name":"pvc-1","csi.storage.k8s.io/pvc/namespace":"default","skuName":"Standard_LRS"},"volume_capabilities":[{"AccessType":{"Mount":{"fs_type":"ext4","mount_flags":["mfsymlinks","cache=strict","nosharesock","actimeo=30"]}},"access_mode":{"mode":7}}]}
I0802 11:27:45.199848       1 controllerserver.go:561] begin to create file share(pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6) on account(clusterewxps) type(Standard_LRS) subID() rg(rbednar-mycluster-01-wnmgz-rg) location() size(1) protocol(SMB)
I0802 11:27:45.586538       1 controllerserver.go:593] create file share pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6 on storage account clusterewxps successfully
I0802 11:27:45.607282       1 controllerserver.go:639] store account key to k8s secret(azure-storage-account-clusterewxps-secret) in default namespace
I0802 11:27:45.607340       1 utils.go:108] GRPC response: {"volume":{"capacity_bytes":1073741824,"volume_context":{"csi.storage.k8s.io/pv/name":"pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6","csi.storage.k8s.io/pvc/name":"pvc-1","csi.storage.k8s.io/pvc/namespace":"default","secretnamespace":"default","skuName":"Standard_LRS"},"volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}}
I0802 11:28:00.070584       1 utils.go:101] GRPC call: /csi.v1.Identity/GetPluginInfo
I0802 11:28:00.070604       1 utils.go:102] GRPC request: {}
I0802 11:28:00.070645       1 utils.go:108] GRPC response: {"name":"file.csi.azure.com","vendor_version":"v1.30.3"}
I0802 11:28:00.071131       1 utils.go:101] GRPC call: /csi.v1.Controller/CreateSnapshot
I0802 11:28:00.071144       1 utils.go:102] GRPC request: {"name":"snapshot-9cde69ce-2e33-4f32-b4ba-471b04549904","source_volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}
I0802 11:28:00.414963       1 controllerserver.go:915] created share snapshot: 2024-08-02T11:28:00.0000000Z, time: 2024-08-02 11:28:00 +0000 UTC, quota: 0GiB
I0802 11:28:00.415040       1 utils.go:108] GRPC response: {"snapshot":{"creation_time":{"seconds":1722598080},"ready_to_use":true,"size_bytes":107374182400,"snapshot_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default#2024-08-02T11:28:00.0000000Z","source_volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default"}}

Driver logs during snapshot restore:

I0802 11:29:33.283200       1 controllerserver.go:1098] copied fileshare pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6(snapshot: 2024-08-02T11:28:00.0000000Z) to pvc-10e9e706-2427-46c4-b988-bf7aa228e718 successfully
I0802 11:29:33.283262       1 controllerserver.go:593] create file share pvc-10e9e706-2427-46c4-b988-bf7aa228e718 on storage account clusterewxps successfully
I0802 11:29:33.283302       1 utils.go:108] GRPC response: {"volume":{"capacity_bytes":107374182400,"content_source":{"Type":{"Snapshot":{"snapshot_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-ce4d6eca-df1c-41dd-bb13-a484c0524ec6###default#2024-08-02T11:28:00.0000000Z"}}},"volume_context":{"csi.storage.k8s.io/pv/name":"pvc-10e9e706-2427-46c4-b988-bf7aa228e718","csi.storage.k8s.io/pvc/name":"pvc-1-snapshot-restore","csi.storage.k8s.io/pvc/namespace":"default","secretnamespace":"default","skuName":"Standard_LRS"},"volume_id":"rbednar-mycluster-01-wnmgz-rg#clusterewxps#pvc-10e9e706-2427-46c4-b988-bf7aa228e718###default"}}

Snapshot restored successfully:

oc get pvc/pvc-1-snapshot-restore
NAME                     STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS    VOLUMEATTRIBUTESCLASS   AGE
pvc-1-snapshot-restore   Bound    pvc-10e9e706-2427-46c4-b988-bf7aa228e718   100Gi      RWO            azurefile-csi   <unset>                 2m23s

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RomanBednar · 2024-08-07T11:01:07Z

cc @jsafrane for review

jsafrane · 2024-08-07T11:57:44Z

pkg/driver/azure-file/azure_file.go

 					"--extra-create-metadata=true",
 					"--timeout=300s",
+					"--worker-threads=100",


The upstream Deployment does not set --worker-threads

jsafrane · 2024-08-07T12:30:30Z

/lgtm

openshift-ci-robot · 2024-08-07T14:33:47Z

/retest-required

Remaining retests: 0 against base HEAD 601e4ce and 2 for PR HEAD 4ad787f in total

jsafrane · 2024-08-07T15:30:21Z

/retest-required
Azure tests have issues pulling from registry.build09.ci.openshift.org !?

duanwei33 · 2024-08-08T00:01:20Z

Many CI failed due to two cases, so just retest.
Run multi-stage test pre phase
Run multi-stage test post phase

/retest-required

openshift-ci · 2024-08-08T02:28:34Z

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-csi-extended	`4ad787f`	link	false	`/test e2e-azure-csi-extended`
ci/prow/e2e-azurestack-csi	`4ad787f`	link	false	`/test e2e-azurestack-csi`
ci/prow/smb-operator-e2e	`4ad787f`	link	false	`/test smb-operator-e2e`
ci/prow/smb-operator-e2e-extended	`4ad787f`	link	false	`/test smb-operator-e2e-extended`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-08-08T05:37:28Z

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-ebs-csi-driver-operator
This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.18.0-202408080513.p0.g0d50e37.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-08-08T05:37:29Z

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.18.0-202408080513.p0.g0d50e37.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-08-08T05:37:30Z

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver-operator
This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.18.0-202408080513.p0.g0d50e37.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-08-08T05:37:30Z

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver-operator
This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.18.0-202408080513.p0.g0d50e37.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-08-08T05:40:29Z

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver-operator
This PR has been included in build ose-smb-csi-driver-operator-container-v4.18.0-202408080513.p0.g0d50e37.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot requested review from jsafrane and mpatlasov August 2, 2024 11:37

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024

RomanBednar force-pushed the azure-file-snapshot-support branch from cbe0379 to ccadce0 Compare August 2, 2024 11:43

jsafrane reviewed Aug 5, 2024

View reviewed changes

RomanBednar force-pushed the azure-file-snapshot-support branch 2 times, most recently from 152133a to 909fcd1 Compare August 6, 2024 11:55

RomanBednar mentioned this pull request Aug 6, 2024

STOR-2002: UPSTREAM: 2040: fix snapshot size openshift/azure-file-csi-driver#73

Merged

RomanBednar changed the title ~~add Azure File snapshot support~~ STOR-2002: add Azure File snapshot support Aug 6, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2024

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 6, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 7, 2024

jsafrane reviewed Aug 7, 2024

View reviewed changes

RomanBednar added 3 commits August 7, 2024 14:23

add snapshot support for Azure File

68614ce

re-generate assets

dc98451

enable Azure File snapshot tests

4ad787f

RomanBednar force-pushed the azure-file-snapshot-support branch from 909fcd1 to 4ad787f Compare August 7, 2024 12:23

openshift-ci bot assigned jsafrane Aug 7, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024

openshift-merge-bot bot merged commit 0d50e37 into openshift:master Aug 8, 2024
20 of 24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STOR-2002: add Azure File snapshot support #253

STOR-2002: add Azure File snapshot support #253

RomanBednar commented Aug 2, 2024 •

edited

Loading

openshift-ci bot commented Aug 2, 2024

RomanBednar commented Aug 2, 2024

jsafrane Aug 5, 2024

RomanBednar Aug 6, 2024

jsafrane Aug 5, 2024

RomanBednar Aug 6, 2024

jsafrane Aug 5, 2024

RomanBednar Aug 6, 2024

RomanBednar commented Aug 6, 2024 •

edited

Loading

openshift-ci-robot commented Aug 6, 2024 •

edited by openshift-ci bot

Loading

Basic verification for snapshot create and restore

dobsonj commented Aug 6, 2024

dobsonj commented Aug 6, 2024

dobsonj commented Aug 6, 2024

duanwei33 commented Aug 7, 2024

duanwei33 commented Aug 7, 2024

openshift-ci bot commented Aug 7, 2024

duanwei33 commented Aug 7, 2024

openshift-ci-robot commented Aug 7, 2024 •

edited by openshift-ci bot

Loading

Basic verification for snapshot create and restore

RomanBednar commented Aug 7, 2024

jsafrane Aug 7, 2024

RomanBednar Aug 7, 2024

jsafrane commented Aug 7, 2024

openshift-ci-robot commented Aug 7, 2024

jsafrane commented Aug 7, 2024

duanwei33 commented Aug 8, 2024

openshift-ci bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

STOR-2002: add Azure File snapshot support #253

STOR-2002: add Azure File snapshot support #253

Conversation

RomanBednar commented Aug 2, 2024 • edited Loading

Basic verification for snapshot create and restore

openshift-ci bot commented Aug 2, 2024

RomanBednar commented Aug 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RomanBednar commented Aug 6, 2024 • edited Loading

openshift-ci-robot commented Aug 6, 2024 • edited by openshift-ci bot Loading

Basic verification for snapshot create and restore

dobsonj commented Aug 6, 2024

dobsonj commented Aug 6, 2024

dobsonj commented Aug 6, 2024

duanwei33 commented Aug 7, 2024

duanwei33 commented Aug 7, 2024

openshift-ci bot commented Aug 7, 2024

duanwei33 commented Aug 7, 2024

openshift-ci-robot commented Aug 7, 2024 • edited by openshift-ci bot Loading

Basic verification for snapshot create and restore

RomanBednar commented Aug 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsafrane commented Aug 7, 2024

openshift-ci-robot commented Aug 7, 2024

jsafrane commented Aug 7, 2024

duanwei33 commented Aug 8, 2024

openshift-ci bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

openshift-bot commented Aug 8, 2024

RomanBednar commented Aug 2, 2024 •

edited

Loading

RomanBednar commented Aug 6, 2024 •

edited

Loading

openshift-ci-robot commented Aug 6, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 7, 2024 •

edited by openshift-ci bot

Loading