-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-2002: add Azure File snapshot support #253
STOR-2002: add Azure File snapshot support #253
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cbe0379
to
ccadce0
Compare
/retest-required |
- --extra-create-metadata=true | ||
- --timeout=300s | ||
- --strict-topology=true | ||
- --timeout=30s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the timeout from 300s to 30s, which is IMO bad.
(upstream uses 1200s !?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1200s seems a lot, I've set 300s now and we can increase it later if we see issues.
@@ -169,8 +173,14 @@ spec: | |||
- --leader-election-retry-period=${LEADER_ELECTION_RETRY_PERIOD} | |||
- --leader-election-namespace=openshift-cluster-csi-drivers | |||
- --v=${LOG_LEVEL} | |||
- --default-fstype=ext4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is bad for Samba / NFS, they don't support ext4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it should be left unset - removing.
- --feature-gates=Topology=true | ||
- --extra-create-metadata=true | ||
- --timeout=300s | ||
- --strict-topology=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes? Topology
and strict-topology
not in the upstream deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a mistake, removing.
152133a
to
909fcd1
Compare
The problem with snapshot restore size turned out to be a bug in the driver. Upstream posted a fix real quick and I've re-tested the failing CI tests with that fix and they passed for me: kubernetes-sigs/azurefile-csi-driver#2040 So we need to wait for upstream merge, follow with a cherry-pick and we should be good with this PR. EDIT: upstream fix is merged now, opening cherry-pick PR |
@RomanBednar: This pull request references STOR-2002 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/retest |
/test e2e-azure-file-csi |
The CI azure-file-csi/azure-file-csi-extended/azure-csi-extended all good. |
/label pe-approved |
@duanwei33: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label qe-approved |
@RomanBednar: This pull request references STOR-2002 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cc @jsafrane for review |
pkg/driver/azure-file/azure_file.go
Outdated
"--extra-create-metadata=true", | ||
"--timeout=300s", | ||
"--worker-threads=100", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream Deployment does not set --worker-threads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
909fcd1
to
4ad787f
Compare
/lgtm |
/retest-required |
Many CI failed due to two cases, so just retest. /retest-required |
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
0d50e37
into
openshift:master
[ART PR BUILD NOTIFIER] Distgit: ose-aws-ebs-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-aws-efs-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-azure-disk-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: azure-file-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver-operator |
Basic verification for snapshot create and restore
Driver logs with successful PVC and snapshot creation:
Driver logs during snapshot restore:
Snapshot restored successfully:
cc @openshift/storage