Conversation
As it mentioned in the gh-action-pypi-publish repo, the master branch version has been sunset and we should use release/v1.
Contributor
Author
|
@CodeWithEmad @MoisesGSalas the AWS credentials are not shared with forked PRs so I made a copy of the PR within the repo and it looks good. @MoisesGSalas longer term it may be useful to re-examine the CI workflows and see if we can drop the need for AWS machines and just run the tests directly on github infrastructure. |
MoisesGSalas
approved these changes
Jul 22, 2024
Contributor
|
Thanks a lot @feanil, I will try to rework those test when I have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it mentioned in the gh-action-pypi-publish repo, the master branch version has been sunset and we should use release/v1.