Skip to content

fix: remove future usages#149

Merged
connorhaugh merged 2 commits intomasterfrom
usamasadiq/remove-future-usages
Feb 8, 2023
Merged

fix: remove future usages#149
connorhaugh merged 2 commits intomasterfrom
usamasadiq/remove-future-usages

Conversation

@UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Jan 18, 2023

Description

  • future package had a security vulnerability which was pointed out some time ago
  • Remove usages of the package future and its dependency from the requirements.

Testing

@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/remove-future-usages branch from b14bf85 to ccda9b8 Compare February 2, 2023 06:48
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/remove-future-usages branch from 91e2703 to 6f64746 Compare February 7, 2023 11:50
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/remove-future-usages branch from 6f64746 to 0de837e Compare February 7, 2023 11:53
@connorhaugh
Copy link

connorhaugh commented Feb 7, 2023

@UsamaSadiq what is your analysis of the security risks of removing this package without replacing it? It seems like we should just replace python 2 code with python 3 code, so it is ok? I just want to ensure future isn't there for security reasons.

@UsamaSadiq
Copy link
Member Author

We don't need to replace future package with any other since it was only used in Python 2 which we've already dropped support for. future wasn't used for any security reasons rather it was used in Python 2 only to use some functions from Python 3.

Copy link

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, after looking more into the package I agree.

@connorhaugh connorhaugh merged commit 94b4398 into master Feb 8, 2023
@connorhaugh connorhaugh deleted the usamasadiq/remove-future-usages branch February 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants