Merged
Conversation
b14bf85 to
ccda9b8
Compare
91e2703 to
6f64746
Compare
6f64746 to
0de837e
Compare
|
@UsamaSadiq what is your analysis of the security risks of removing this package without replacing it? It seems like we should just replace python 2 code with python 3 code, so it is ok? I just want to ensure |
Member
Author
|
We don't need to replace |
connorhaugh
approved these changes
Feb 8, 2023
connorhaugh
left a comment
There was a problem hiding this comment.
Thanks, after looking more into the package I agree.
This was referenced Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
futurepackage had a security vulnerability which was pointed out some time agofutureand its dependency from the requirements.Testing