This repository was archived by the owner on Aug 22, 2023. It is now read-only.
fix: just set exit code, do not force termination#138
Open
jonathanmorley wants to merge 1 commit intooclif:mainfrom
Open
fix: just set exit code, do not force termination#138jonathanmorley wants to merge 1 commit intooclif:mainfrom
jonathanmorley wants to merge 1 commit intooclif:mainfrom
Conversation
Oclif should wait for other tasks to complete gracefully, and not force them to exit
|
Thanks for the contribution! Before we can merge this, we need @jonathanmorley to sign the Salesforce.com Contributor License Agreement. |
Contributor
|
It could be debated. What task are you waiting to finish? Otherwise, a command could error but the process could hang for a while. For individual commands, you could override the catch on the command to wait for any additional processing. I'm not saying we shouldn't do this, just wanted to discuss a little more before something like this would be changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oclif should wait for other tasks to complete gracefully, and not force them to exit