Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

fix: just set exit code, do not force termination#138

Open
jonathanmorley wants to merge 1 commit intooclif:mainfrom
cvent:just-exitcode
Open

fix: just set exit code, do not force termination#138
jonathanmorley wants to merge 1 commit intooclif:mainfrom
cvent:just-exitcode

Conversation

@jonathanmorley
Copy link

Oclif should wait for other tasks to complete gracefully, and not force them to exit

Oclif should wait for other tasks to complete gracefully, and not force them to exit
@salesforce-cla
Copy link

salesforce-cla bot commented Mar 1, 2021

Thanks for the contribution! Before we can merge this, we need @jonathanmorley to sign the Salesforce.com Contributor License Agreement.

@amphro
Copy link
Contributor

amphro commented May 10, 2021

It could be debated. What task are you waiting to finish? Otherwise, a command could error but the process could hang for a while.

For individual commands, you could override the catch on the command to wait for any additional processing.
For CLIs, you don't need to use errors/handle. It is a relatively small thing to swap out with your own function.

I'm not saying we shouldn't do this, just wanted to discuss a little more before something like this would be changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants