Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth support for NVM_AUTH_HEADER env var #3380

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Auth support for NVM_AUTH_HEADER env var #3380

merged 3 commits into from
Jul 26, 2024

Conversation

dwelch2344
Copy link
Contributor

@dwelch2344 dwelch2344 commented Jun 21, 2024 •
edited
Loading

A simple POC to build from, but wanted to open for feedback on #3366

@dwelch2344 dwelch2344 changed the title [New] Add support for NVM_AUTH_HEADER env var Auth support for NVM_AUTH_HEADER env var Jun 21, 2024
@dwelch2344 dwelch2344 mentioned this pull request Jun 21, 2024
Closed
ljharb
ljharb reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It'll need some tests ofc.

nvm.sh Outdated Show resolved Hide resolved
nvm.sh Outdated Show resolved Hide resolved
nvm.sh Outdated Show resolved Hide resolved
ljharb
ljharb reviewed Jun 27, 2024
View reviewed changes
nvm.sh Outdated Show resolved Hide resolved
@dwelch2344 dwelch2344 marked this pull request as ready for review June 28, 2024 15:19
ljharb
ljharb requested changes Jun 29, 2024
View reviewed changes
test/fast/Unit tests/nvm_download Outdated Show resolved Hide resolved
nvm.sh Outdated Show resolved Hide resolved
nvm.sh Outdated Show resolved Hide resolved
nvm.sh Outdated Show resolved Hide resolved
@ljharb ljharb added installing node Issues with installing node/io.js versions. feature requests I want a new feature in nvm! labels Jun 29, 2024
@ljharb ljharb force-pushed the auth_header branch 2 times, most recently from 2bf3f9a to 78e9f45 Compare July 1, 2024 20:53
ljharb
ljharb approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ljharb ljharb closed this Jul 4, 2024
@ljharb ljharb reopened this Jul 4, 2024
@ljharb ljharb force-pushed the auth_header branch 5 times, most recently from 016af9d to 8fcd4ab Compare July 6, 2024 19:13
@ljharb ljharb force-pushed the auth_header branch 2 times, most recently from 981d19c to 29331ff Compare July 23, 2024 02:17
@ljharb ljharb closed this Jul 26, 2024
@ljharb ljharb reopened this Jul 26, 2024
@ljharb ljharb merged commit bd090ef into nvm-sh:master Jul 26, 2024
110 checks passed
@ljharb ljharb mentioned this pull request Aug 15, 2024
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narfdre narfdre narfdre left review comments

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwelch2344 @ljharb @narfdre