Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InputMenu/SelectMenu): correctly call onSelect events #3735

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

zAlweNy26
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I noticed that after the commit b998354, the onSelect events of InputMenu and SelectMenu weren't working anymore.
I'm sorry I didn't open an issue, but showing the code was easier to explain to me.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Mar 30, 2025

npm i https://pkg.pr.new/@nuxt/ui@3735

commit: b195df4

@benjamincanac benjamincanac requested a review from sandros94 March 30, 2025 08:44
@benjamincanac benjamincanac changed the title fix: correctly call onSelect events fix(InputMenu/SelectMenu): correctly call onSelect events Mar 30, 2025
@benjamincanac benjamincanac merged commit f25fed5 into nuxt:v3 Mar 31, 2025
5 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

@benjamincanac benjamincanac added the v3 #1289 label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants