Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InputNumber): add support for stepSnapping & disableWheelChange props #3731

Merged

Conversation

robinsimonklein
Copy link
Contributor

@robinsimonklein robinsimonklein commented Mar 29, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Reka UI recently added two new props to the NumberField component, in the v2.1.0 release. I simply added them in the InputNumber component so we can also use them in Nuxt UI :)

  • stepSnapping: When false, prevents the value from snapping to the nearest increment of the step value.
  • disableWheelChange: When true, prevents the value from changing on wheel scroll.

πŸ“ Checklist

  • I have linked an issue or discussion.

β†’ Didn't find an issue or discussion about that πŸ€·β€β™‚οΈ

  • I have updated the documentation accordingly.

β†’ Not sure if these props deserve a dedicated example in the "Usage" or "Example" section. Maybe we could add a tip about stepSnapping in the "Step" usage section instead?

Copy link

pkg-pr-new bot commented Mar 29, 2025

npm i https://pkg.pr.new/@nuxt/ui@3731

commit: 9a4c6c1

@benjamincanac benjamincanac changed the title feat(InputNumber): Implement new props from Reka UI : stepSnapping & disableWheelChange feat(InputNumber): add support for stepSnapping & disableWheelChange props Mar 31, 2025
@benjamincanac benjamincanac merged commit f5e6284 into nuxt:v3 Mar 31, 2025
5 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊 No need to add a dedicated example for each Reka UI props, there are way too many πŸ˜…

@benjamincanac benjamincanac added the v3 #1289 label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants