Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useOverlay): refine open method type to infer close emit return type #3716

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

genu
Copy link
Contributor

@genu genu commented Mar 28, 2025

πŸ”— Linked issue

Resolves #3706

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Update the return type of the open method to infer the type that is emitted in the close event

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Mar 28, 2025

npm i https://pkg.pr.new/@nuxt/ui@3716

commit: 4e5241a

@benjamincanac benjamincanac changed the title fix(useOverlay): refine open method type to infer close emit return… fix(useOverlay): refine open method type to infer close emit return type Mar 28, 2025
@benjamincanac benjamincanac merged commit bd99c2d into nuxt:v3 Mar 28, 2025
5 checks passed
@benjamincanac
Copy link
Member

Thanks @genu! 😊

@genu genu deleted the feature/infer_return_type branch March 28, 2025 18:41
@benjamincanac benjamincanac added the v3 #1289 label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infer Return Type of useOverlay().open Based on Component Emits
2 participants