Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useLocale): unique symbol to use in @nuxt/ui-pro #3603

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Conversation

benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Mar 18, 2025

πŸ”— Linked issue

Resolves #3549

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Mar 18, 2025

npm i https://pkg.pr.new/@nuxt/ui@3603

commit: e0f5183

@benjamincanac benjamincanac changed the title fix(locale): move injection key in utils fix(useLocale): unique symbol to use in @nuxt/ui-pro Mar 18, 2025
@benjamincanac benjamincanac requested a review from hywax March 18, 2025 11:01
Copy link
Contributor

nuxthub-admin bot commented Mar 18, 2025

βœ… Deployed ui3

Deployed ui3 e0f5183 to preview

πŸ”— pr-3549.ui-6q2.pages.dev
πŸ“Œ ae36df61.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

@benjamincanac
Copy link
Member Author

@hywax I had to use Symbol.for because when used in @nuxt/ui-pro the injection wasn't working: https://github.com/nuxt/ui-pro/blob/v3/src/runtime/composables/useLocalePro.ts#L11

@benjamincanac benjamincanac marked this pull request as ready for review March 18, 2025 11:08
@benjamincanac benjamincanac merged commit dec2730 into v3 Mar 18, 2025
4 checks passed
@benjamincanac benjamincanac deleted the pr/3549 branch March 18, 2025 11:09
@benjamincanac benjamincanac added the v3 #1289 label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

injection "Symbol(nuxt-ui.locale-context)" not found
1 participant