docs(migration): improve useOverlay section
#3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi,
I have faced the $emit('closed') or emit('closed') not working, I just check with the close word only, It will work
Thanks
|
@genu Does this seem correct to you? |
commit: |
genu
reviewed
Mar 18, 2025
| @@ -458,8 +458,8 @@ const toast = useToast() | |||
| Some important differences: | |||
| - The `useOverlay` composable is now used to create overlay instances | |||
| - Overlays that are opened, can be awaited for their result | |||
| - Overlays can no longer be closed using `modal.close()` or `slideover.close()`, rather, they close automatically: either when a `closed` event is fired explicitly from the opened component OR when the overlay closes itself (clicking on backdrop, pressing the ESC key, etc) | |||
There was a problem hiding this comment.
Overlays can no longer be closed using...
This is correct
... either when a
closedevent is fired explicitly...
You're right, this should be close
There was a problem hiding this comment.
Yes,
Thank you @genu
| @@ -496,7 +496,7 @@ const count = ref(0) | |||
| </script> | |||
| ``` | |||
|
|
|||
| Closing a modal is now done through the `closed` event. The `modal.open` method now returns a promise that resolves to the result of the modal whenever the modal is closed: | |||
There was a problem hiding this comment.
whenever the modal is closed
This is correct, lets keep this.
now done through the
closedevent
You're right here, should be close
useOverlay section
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I encountered an issue where
$emit('closed')oremit('closed')was not working. However, when I used onlyclose, it worked as expected.Could you please help clarify this behaviour?
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist