Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): missing unhead context #3589

Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix(vue): missing unhead context #3589

merged 3 commits into from
Mar 17, 2025

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Mar 17, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The Vue context is not set when we're executing plugins which is causing the Unhead instance to not be available.

We also tidy up some of the input:

  • Prefer relative tagPriority which will ensure Capo.js sorting is correctly applied
  • Missing type
  • type="text/css" is not typed as it's deprecated, better to just remove it

& fix an issue where the Unhead instance will be replaced if it's already installed.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Contributor

nuxthub-admin bot commented Mar 17, 2025

βœ… Deployed ui3

Deployed ui3 21083bf to preview

πŸ”— fix-vue-unhead-context.ui-6q2.pages.dev
πŸ“Œ c063a5a4.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

Copy link

pkg-pr-new bot commented Mar 17, 2025

npm i https://pkg.pr.new/@nuxt/ui@3589

commit: 21083bf

@benjamincanac benjamincanac changed the title fix(vue): missing Vue Unhead context fix(vue): missing unhead context Mar 17, 2025
@benjamincanac benjamincanac merged commit 0897e9e into v3 Mar 17, 2025
4 checks passed
@benjamincanac benjamincanac deleted the fix/vue-unhead-context branch March 17, 2025 14:09
@benjamincanac
Copy link
Member

Thanks @harlan-zw! 😊

benjamincanac added a commit that referenced this pull request Mar 17, 2025
@benjamincanac benjamincanac added the v3 #1289 label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants