Fixed showing images in the Pairing tutorial #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
There is an option for the myst parser to enable raw html images: you can add "html_image" to the myst_enable_extensions list in conf.py. Unfortunately AIUI the myst-parser does not currently pass through raw html images that are within other html elements, so this option wouldn't help here.
There are however other options to achieve similar behavior with MyST itself - see the suggestion below. Either way, I'm +1 on getting rid of the raw html and happy to replace it with either option.
Co-authored-by: Ross Barnowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered by accident that the animated gifs in the pairing tutorial were not showing properly. After some experimentation it appears that if we use html syntax for images, the site is not build correctly - the path for the images ends up wrong. But if we change it to markdown syntax, all works well. So unless we know a fix, I'm suggesting we remove the nice folding html tag for now.