Skip to content

Converts "Deep Learning on MNIST" tutorial to md. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

melissawm
Copy link
Member

@rossbar can you please take a look when you have the time, let me know if this is the right way to do this?

@8bitmp3 if you see anything wrong with the formatting or content, please let me know.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@melissawm
Copy link
Member Author

There is a remaining issue that would be nice to sort out, which is that the last code cell times out when executed via make. Is there a way we can skip that cell when making the HTML site? (We can include a markdown comment about the outputs for users but the cell doesn't have to get executed automatically when building the site). This will surely happen again in the Pong tutorial as well.

Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melissawm yup that's exactly it 👍

The only issue that cropped up for me was an execution timeout - this example has significantly longer runtimes than the others.

Fortunately, you can control this at the cell, notebook, or project-level with various metadata/configuraiton options. I added a longer timeout to the conf.py in be87354 to demonstrate this. We may need to expand that further when we deploy via CI (which I hope to work on today/tomorrow).

@melissawm
Copy link
Member Author

Great, thanks @rossbar !

@melissawm melissawm merged commit c77783b into numpy:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants