Skip to content

CI: Add CIRCLE_TOKEN to fix artifact redirection. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

rossbar
Copy link
Collaborator

@rossbar rossbar commented Apr 20, 2023

Copy of numpy/numpy#23578 to fix static site preview link in CI.

This will only work if CIRCLE_TOKEN is available, and unfortunately we won't know whether this works until after merge.

This will only work if CIRCLE_TOKEN is available.
@bsipocz bsipocz added the infrastructure Issues relevant to infrasructure, rather than content label Apr 20, 2023
@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2023

OK, let's try this.

@bsipocz bsipocz merged commit 5d5889e into numpy:main Apr 20, 2023
@rossbar rossbar deleted the fix-artifact-redirector branch April 20, 2023 18:01
@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2023

I think it worked? We only got two triggers, and indeed have two workflows. I'll rebase the windows PR as a double check as that one should be good to go.

@rossbar
Copy link
Collaborator Author

rossbar commented Apr 20, 2023

I think it worked? We only got two triggers, and indeed have two workflows. I'll rebase the windows PR as a double check as that one should be good to go.

Well the good news is I don't think we have to revert anything, we just have to get the secrets configured properly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues relevant to infrasructure, rather than content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants