Skip to content

Removed sphinx and added binder #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Conversation

melissawm
Copy link
Member

@melissawm melissawm commented Aug 4, 2020

After discussions with the documentation team, we decided to make this repo simpler and remove sphinx, using only Binder for rendering notebooks.

This PR updates the configuration of the repo, removes unnecessary configuration files and includes gh-actions configurations to trigger rendering the notebooks (with binder) in issue/PR comments - see more details here.

Closes #5 and #10.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for doing this, thanks @melissawm

@rgommers
Copy link
Member

rgommers commented Aug 4, 2020

Gave the button a quick try. Binder starts in the repo root. Can you make it start in content/ instead? That's the only directory that users should be accessing right?

@melissawm
Copy link
Member Author

Hi @rgommers , just a ping to see if there's anything else left to do before we merge this :)

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Melissa!

@rgommers rgommers merged commit 4772649 into numpy:master Aug 18, 2020
@rgommers
Copy link
Member

It's not happy yet, may be because it's still building, but need to check on this later:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check out online rendering of notebooks (i.e. Binder)
2 participants