Skip to content

CI: Update circleci deploy key #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

rossbar
Copy link
Collaborator

@rossbar rossbar commented Jan 5, 2023

@rossbar rossbar added the infrastructure Issues relevant to infrasructure, rather than content label Jan 5, 2023
@bsipocz
Copy link
Member

bsipocz commented Jan 5, 2023

Failure is unrelated (and is due to sphinx 5+ is being picked up). Something goes really wrong in the infra, somehow a lot of wheels are downloaded: https://app.circleci.com/pipelines/github/numpy/numpy-tutorials/434/workflows/d2896d6a-88ff-468b-a4fe-0107f1282b2b/jobs/512?invite=true#step-102-157

I suggest to tackle it separately.

@rossbar
Copy link
Collaborator Author

rossbar commented Jan 5, 2023

I suggest to tackle it separately.

Agreed - I pushed up a pin in an effort to fix it only to try to get the circleci job to run to completion. I will back it out before merging so that the only thing that in this PR is the fingerprint update!

@bsipocz bsipocz mentioned this pull request Jan 5, 2023
@bsipocz bsipocz force-pushed the circleci-update-key branch from cb79565 to f498351 Compare January 5, 2023 23:15
@bsipocz
Copy link
Member

bsipocz commented Jan 5, 2023

Hmm, all seems to be fine, and deployed, even without this, so I'm not sure we in fact need the ssh key?

@rossbar
Copy link
Collaborator Author

rossbar commented Jan 5, 2023

Hmm, all seems to be fine, and deployed, even without this, so I'm not sure we in fact need the ssh key?

Well the deploy job is green, but the key (on the github settings page) still shows as "never used", so I assume that the job passes even if the push to gh-pages never comes off. We won't be able to tell in this case because we haven't changed the content of the website.

@bsipocz
Copy link
Member

bsipocz commented Jan 5, 2023

Files have changed on the gh-pages branch though, I think it actually relies on the deploy token or webhook, but I don't see those tabs in the settings to double check:

Screenshot 2023-01-05 at 15 34 16

@rossbar rossbar force-pushed the circleci-update-key branch from f498351 to 22cee52 Compare January 6, 2023 00:21
@rossbar rossbar merged commit 01aad12 into numpy:main Jan 6, 2023
@rossbar rossbar deleted the circleci-update-key branch January 6, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues relevant to infrasructure, rather than content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants