fix: ignore ENOTDIR errors
#176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug with `map-workspaces` over-aggressively inspecting symbolic links to files as workspaces. When this happens, an `ENOTDIR` error is thrown. We should be able to safely ignore that error just like `ENOENT`, which fixes the root cause of the referenced bug. fixes npm/cli#7834
This was referenced Oct 21, 2024
Member
|
This will need a test to cover the new code path. |
ENOTDIR errors
Contributor
Author
|
@wraithgar thanks for that. Test added! |
Contributor
Author
|
@wraithgar just checking back in on this. Is there anything I can do to help move this forward? Thank you 🙏 |
Member
|
|
Contributor
Author
|
@wraithgar thanks, updated! |
wraithgar
approved these changes
Nov 20, 2024
Merged
wraithgar
pushed a commit
that referenced
this pull request
Nov 20, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.2](v4.0.1...v4.0.2) (2024-11-20) ### Bug Fixes * [`ae9cd9e`](ae9cd9e) [#176](#176) ignore `ENOTDIR` errors (#176) (@brianlenz) ### Chores * [`84d179f`](84d179f) [#174](#174) bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#174) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug with
map-workspacesover-aggressively inspecting symbolic links to files as workspaces. When this happens, anENOTDIRerror is thrown. We should be able to safely ignore that error just likeENOENT, which fixes the root cause of the referenced bug.fixes npm/cli#7834