Skip to content

dns: export error code constants from dns/promises #43176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 18, 2022
Merged

dns: export error code constants from dns/promises #43176

nodejs-github-bot merged 1 commit into from
Jun 18, 2022

Conversation

@F3n67u
Copy link
Contributor

@F3n67u F3n67u commented May 22, 2022 •
edited
Loading

Fix #43140

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels May 22, 2022
@F3n67u F3n67u force-pushed the promise-constants branch 2 times, most recently from 33ce958 to 3f35532 Compare May 22, 2022 13:16
@F3n67u F3n67u changed the title lib: re-export error code constants from dns/promises dns: re-export error code constants from dns/promises May 22, 2022
@F3n67u F3n67u marked this pull request as ready for review May 22, 2022 14:56
@F3n67u F3n67u force-pushed the promise-constants branch 5 times, most recently from b46aa7c to 8bd9ced Compare May 27, 2022 14:25
@F3n67u F3n67u changed the title dns: re-export error code constants from dns/promises dns: export error code constants from dns/promises May 27, 2022
@F3n67u F3n67u force-pushed the promise-constants branch 2 times, most recently from bface29 to 35b71a2 Compare May 27, 2022 15:06
@F3n67u F3n67u force-pushed the promise-constants branch from 35b71a2 to 2d28771 Compare May 27, 2022 15:10
@F3n67u
Copy link
Contributor Author

F3n67u commented May 28, 2022 •
edited
Loading

The Node.js bot doesn't notify this pr to review.

@aduh95 Could you help me to @nodejs/net team to review this pr? Thanks!

@aduh95
Copy link
Contributor

aduh95 commented May 31, 2022 •
edited
Loading

/cc @nodejs/net @nodejs/dns

mcollina
mcollina approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 7, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 7, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44400/

@F3n67u
Copy link
Contributor Author

F3n67u commented Jun 11, 2022

@aduh95 jeninks failure is not related to this pr, could you help to rerun jenkins ci?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44444/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44445/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44463/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44467/

@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Open
15 tasks
This was referenced Jun 15, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44640/

@github-actions github-actions bot mentioned this pull request Jun 18, 2022
Open
34 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44673/

@F3n67u F3n67u mentioned this pull request Jun 18, 2022
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44687/

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jun 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 18, 2022
@nodejs-github-bot nodejs-github-bot merged commit dc53c29 into nodejs:main Jun 18, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2022

Landed in dc53c29

@F3n67u F3n67u deleted the promise-constants branch June 18, 2022 12:56
This was referenced Jun 19, 2022
Open
Open
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 12, 2022
@targos targos mentioned this pull request Jul 12, 2022
Merged
@targos targos mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@JungMinu JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dns Issues and PRs related to the dns subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-export error code constants from dns/promises

7 participants

@F3n67u @aduh95 @nodejs-github-bot @mcollina @jasnell @JungMinu @targos