Repaired README example for point clouds#294
Merged
nmwsharp merged 1 commit intonmwsharp:masterfrom Oct 2, 2024
Merged
Conversation
Contributor
Author
|
And BTW: I was able to very easily integrate your library into my cmake project by using the FetchContent functionality of cmake. I am not sure if it's written somewhere in the Docs. Here is my CMakeLists.txt: cmake_minimum_required(VERSION 3.11)
project(polyscope_test)
include(FetchContent)
FetchContent_Declare(
polyscope
GIT_REPOSITORY https://github.com/nmwsharp/polyscope.git
GIT_TAG master
)
FetchContent_MakeAvailable(polyscope)
add_executable(polyscope_test
src/polyscope_test.cpp)
target_link_libraries(polyscope_test
polyscope) |
Owner
|
thank you for the fix! |
Owner
|
I am also integrating the FetchContent example you gave into the docs, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I tried your library for rendering a point cloud and used parts of your README as an example. The C++ example seemed to be missing an include and a semicolon. Here is the PR to fix that.
Thanks for publishing this great library
-- Alex