-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do Not Review: Add support for multiple gateways #3275
base: change/control-data-plane-split
Are you sure you want to change the base?
Do Not Review: Add support for multiple gateways #3275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3275 +/- ##
===================================================================
+ Coverage 89.74% 95.19% +5.44%
===================================================================
Files 109 1 -108
Lines 11150 229 -10921
Branches 50 62 +12
===================================================================
- Hits 10007 218 -9789
+ Misses 1083 11 -1072
+ Partials 60 0 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8b7192b
to
33a4cb7
Compare
internal/mode/static/handler.go
Outdated
// the correct Graph for the Deployment contained in the update message | ||
// get the deploymentName from the item | ||
deploymentName := item.Deployment | ||
if deploymentName == (types.NamespacedName{}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If deployment name is empty, we still need to update gatewayclass status. Look to see where we call Enqueue, you'll notice a few that don't set the name.
33a4cb7
to
adb0e1b
Compare
2e13294
to
efd9397
Compare
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want to be able to configure multiple gateways
Solution: Allows users to configure multiple gateways
Testing:
Manual testing:
Scenarios
Existing tutorials tested:
Closes #3219
Closes #3213
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.