Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Review: Add support for multiple gateways #3275

Draft
wants to merge 5 commits into
base: change/control-data-plane-split
Choose a base branch
from

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users want to be able to configure multiple gateways

Solution: Allows users to configure multiple gateways

Testing:

  1. Added unit tests and fixed functional tests

Manual testing:

Scenarios

Existing tutorials tested:

Closes #3219
Closes #3213

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Add support for multiple gateways

@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Apr 1, 2025
@salonichf5 salonichf5 changed the title Add support for multiple gateways Do Not Review: Add support for multiple gateways Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (6337c97) to head (efd9397).
Report is 184 commits behind head on change/control-data-plane-split.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3275      +/-   ##
===================================================================
+ Coverage                            89.74%   95.19%   +5.44%     
===================================================================
  Files                                  109        1     -108     
  Lines                                11150      229   -10921     
  Branches                                50       62      +12     
===================================================================
- Hits                                 10007      218    -9789     
+ Misses                                1083       11    -1072     
+ Partials                                60        0      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 force-pushed the feat/multiple-gateways branch from 8b7192b to 33a4cb7 Compare April 2, 2025 16:11
// the correct Graph for the Deployment contained in the update message
// get the deploymentName from the item
deploymentName := item.Deployment
if deploymentName == (types.NamespacedName{}) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If deployment name is empty, we still need to update gatewayclass status. Look to see where we call Enqueue, you'll notice a few that don't set the name.

@salonichf5 salonichf5 force-pushed the feat/multiple-gateways branch from 33a4cb7 to adb0e1b Compare April 4, 2025 14:50
@salonichf5 salonichf5 force-pushed the feat/multiple-gateways branch from 2e13294 to efd9397 Compare April 7, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-notes tests Pull requests that update tests
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants