Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint to v2 #3269

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Update golangci-lint to v2 #3269

merged 2 commits into from
Mar 31, 2025

Conversation

sjberman
Copy link
Collaborator

Migrate and update the linter to v2 and fix some small issues.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Migrate and update the linter to v2 and fix some small issues.
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (ddb5423) to head (f6de348).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3269   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files         113      113           
  Lines       11664    11664           
  Branches       62       62           
=======================================
  Hits        10050    10050           
  Misses       1553     1553           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) March 31, 2025 17:56
@sjberman sjberman merged commit 91cd21b into main Mar 31, 2025
40 checks passed
@sjberman sjberman deleted the chore/linter-update branch March 31, 2025 18:14
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants