Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP/DP Split: handle kill signal #3260

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Mar 24, 2025

Problem: The data plane container was not properly handling the kill signal when the Pod was Terminated.

Solution: Update the entrypoint to catch the proper signals.

Testing: Verified that the Pod is terminated immediately instead of hanging.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sjberman sjberman requested a review from a team as a code owner March 24, 2025 14:24
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (6337c97) to head (12242aa).
Report is 184 commits behind head on change/control-data-plane-split.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3260      +/-   ##
===================================================================
- Coverage                            89.74%   86.79%   -2.96%     
===================================================================
  Files                                  109      124      +15     
  Lines                                11150    14292    +3142     
  Branches                                50       62      +12     
===================================================================
+ Hits                                 10007    12405    +2398     
- Misses                                1083     1751     +668     
- Partials                                60      136      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Problem: The data plane container was not properly handling the kill signal when the Pod was Terminated.

Solution: Update the entrypoint to catch the proper signals.
@sjberman sjberman merged commit de0fdc2 into change/control-data-plane-split Mar 31, 2025
28 of 37 checks passed
@sjberman sjberman deleted the chore/sigterm branch March 31, 2025 16:49
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants