-
-
Notifications
You must be signed in to change notification settings - Fork 221
Tracy\Bar's output can be disabled (closes #82) #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1, although Btw: the commit message should probably be: "Bar: output can be disabled [Closes #82]" |
src/Tracy/Bar.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both functions take no arguments
|
Thanks @JanTvrdik , I've changed the commit message and fixed PhpDoc. @JanTvrdik But I can change it to only one method eg. |
|
What about simple method |
|
I've replaced the two methods with one But "disable" sounds me better than "hide"... maybe... And I also thinking about option for enabling the Bar again when is disabled. Maybe it's not necessary to have this option. |
|
Maybe |
|
Whats the status of this, please? |
|
please merge this. disable/enable or hide/show are both good names. but it's a pain in the ass to develop a rest api with the bar output in the response |
|
@bazo Send the correct Content-Type header. |
|
ok, that helped. but still, this can be a useful feature |
9151150 to
00083f3
Compare
0203000 to
0203000
Compare
|
+1, i am already using forked version with this merged. |
|
Wait for v2.4 :) |
13f9a7b to
0c0f9d4
Compare
3495a54 to
8517fdc
Compare
5bee3a1 to
42ed404
Compare
Closes #82