Display AJAX bar for Fetch requests #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds AJAX debug bar support for requests made via Fetch API instead of
XMLHttpRequest.There is one caveat which, however, should imo be addressed in the userland:
fetch()must be sent withcredentialsset toincludeorsame-originfor the cookies to be passed and thus for the debug bar session storage to work. This implementation sanely defaults tosame-originif the option is not provided, but if the user sends their ownRequestobject, thecredentialsoption defaults toomitif not provided, and cannot be overridden. I believe it should be left up to the user to handle such situations.