HtmlGenerator: Not loaded source files was not counted to coverage

[jkuchar]

Source files that was not loaded when executing tests was not counted to coverage. This produces false results.

I've added estimator of executable lines. What do you think about this prototype? I'm not sure about duplicating code between CloverXMLGenerator and HtmlGenerator. PhpParser can provide quite accurate data for estimate of lines that can be estimated.

[milo]

Imho, estimation can be more rough. It never will be precise anyway. What about only removing empty lines and count the rest? It will be very pessimistic, but imho OK for this purpose.

[jkuchar]

I've done exactly this in first prototype. Removing comment blocks and counting lines gives ~2x times more lines then this filtered version. This gives developer motivation to have at least some test for each file. Because even loading that file will increase coverage. :) Do you like counting lines with PhpParser more or with regex I've proposed?

Or what about counting only functions/methods lines count returned by PhpParser?

[milo]

PhpParser is overkill here. Imho, this regexp too (it's not 100% correct). Just remove empty lines, it will be super pessimistic, but who cares in this case.

[jkuchar]

:+1 (will fix this tomorrow)

[jkuchar]

@milo fixed and rebased onto master

[dg]

This will not work with \r\n. What about count(file($file, FILE_SKIP_EMPTY_LINES))

[jkuchar]

Thanks! I didn't know about that one. Fixed in cebe26d

[jkuchar]

@dg removed comment

[jkuchar]

@milo is there anything more to do with this PR?

[milo]

Thank you. I missed the renewed commit.