United client- and server-side validation of float (closes #1430)

[redhead]

This pull request unites client-side validation of the 'float' rule with the server-side counterpart.

The problem was in failing validation when a comma was used as a decimal point and/or spaces used as thousand separators. Both are handled on the server side by stripping spaces and replacing comma with period.

[pavelkouril]

Hmmm, so it will fail on numbers written in 1,999.99 format?

[redhead]

Yes. Just like the server-side validation does from the beginning (see docs).

Of course it would be better to implement some kind of locale support in Nette. This pull request, however, just fixes a filed issue.

[dg]

This is more a workaround than a solution. On the server side validator float changes the value, so the following rules are already working with the changed value. Thus not only the range.

[redhead]

Not sure what you mean. What would be your proposed solution?

[dg]

You don't have to fix validator 'range', just 'float'.

[redhead]

This would mean bigger refactoring since the validators on the client-side can't change values in the current implementation.

[dg]

Exactly.

[redhead]

I found out pretty questionable feature - server-side range validator can handle string values as well (all comparable types in fact), eg. array('a', 'g'), however, javascript range validator forces the value to be parsed as float. The current inconsistency makes it harder to unite the two.

It is evident in the description of bug #1430, where you need to add rule float so the comma and thousand separators are handled and value is changed. But if you omit the float rule, server-side validator just compares the given values as they are, but the client side parses it as float (no matter if the float rule was added).

[redhead]

Bump

[dg]

Yes, parseFloat should be removed from JS function range.

[janedbal]

What is missing for completing this issue?

[dg]

see #1462 (comment)

[janedbal]

Thanks, is there any workaround? Ideally without modifying original script.

[janedbal]

@dg Great, thanks for resolving!