[test] add Neon node re-print tests for list #63
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
added a commit
that referenced
this pull request
Nov 10, 2021
ad0f8b4 to
90abe95
Compare
Member
|
fixed |
Author
|
Wow, you're super fast. Thank you 👍 |
dg
added a commit
that referenced
this pull request
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for new AST feature for NEON :).
This will make Nette upgrades even easier and allows to analyse configs with static analysis 👍
I tried prototype in automated upgrade and 3.3.0 worked quite well.
Since 3.3.1, there is a bug in simple list reprint.:
Looks like first nested line is removed. I looked into diff of 3.3.0 and 3.3.1, but could not find anything uesful.
But maybe I'm using printer it wrong. How can I help to fix this?
Thank you 👍