Skip to content

Message: use FileSystem::read() instead of native file_get_contents() #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
May 13, 2020
Merged

Message: use FileSystem::read() instead of native file_get_contents() #69

dg merged 1 commit into from
May 13, 2020

Conversation

@janbarasek
Copy link
Contributor

@janbarasek janbarasek commented May 13, 2020

  • new feature
  • BC break? no

I think Nette\Utils\FileSystem::read is more better than native file_get_contents() for safe reading file.

@dg dg changed the title Message: createAttachment: Use FileSystem::read() instead of native file_get_contents() Message: use FileSystem::read() instead of native file_get_contents() May 13, 2020
@dg dg merged commit aefc1f9 into nette:master May 13, 2020
dg pushed a commit that referenced this pull request May 14, 2020
@janbarasek @dg
use FileSystem::read() instead of native file_get_contents() (#69)
b4027a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janbarasek @dg